Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Tweak update-dialog style #7636

Merged
merged 4 commits into from
May 2, 2014

Conversation

marcelgerber
Copy link
Contributor

@larz0 This makes the UpdateNotification dialog look less weird.

  • Remove the padding-bottom so that the scroll content fills the complete .modal-body
  • Increase the max-height so that more changes are shown at once

@JeffryBooher
Copy link
Contributor

Open to @larz0 to take a look

@larz0
Copy link
Member

larz0 commented Apr 29, 2014

@SAplayer @JeffryBooher looks good! We should do the same to About dialog as well. (Cc'ing @njx just in case.)

@TomMalbran
Copy link
Contributor

It still looks weird that the scrollbars are not against the border of the dialog. It will look best if the entire right column scrolled. We can do this by moving the overflow and max-height to .update-text, remove the margin right, add a padding and add the no-padding class to the modal-body in the updates template. Something similar can be done in the About dialog.

@marcelgerber
Copy link
Contributor Author

@larz0 @TomMalbran Pushed. The about-dialog has a changed style as well. Notice that the Brackets on the very top is scrolling as well now, while it wasn't before.

I didn't merge master in 'cause the new update info url, brackets.io/updates/stable/, is not yet working, so it would be much more difficult to test

@larz0
Copy link
Member

larz0 commented Apr 30, 2014

@SAplayer awesome. Just need to make sure the top of "Brackets" needs to line up with the top of the logo.

screen shot 2014-04-30 at 1 36 10 pm

@larz0
Copy link
Member

larz0 commented Apr 30, 2014

.about-dialog .modal-body h2 {
...
margin-top: 13px;
}

@@ -964,14 +966,15 @@ a[href^="http"] {
}
.about-text {
// Icon is 120px, so we need at least that much left padding/margin to avoid overlap
margin: 0 10px 0 123px;
margin-left: 123px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make it 130px so there's more spacing between the logo and text.

@TomMalbran
Copy link
Contributor

@SAplayer It looks a lot better now. I think that it is ok that the Brackets title scrolls. Maybe that Brackets title should go to the dialog title, so it should say About Brackets.

@larz0
Copy link
Member

larz0 commented Apr 30, 2014

@TomMalbran @SAplayer yep I think it's okay to keep "Brackets" title next to the icon.

@larz0
Copy link
Member

larz0 commented Apr 30, 2014

Could we add spacing below the last row of Github pics. Should be the same as the spacing above "Brackets".

screen shot 2014-04-30 at 3 12 28 pm

@marcelgerber
Copy link
Contributor Author

Changes pushed.

image
image

@TomMalbran
Copy link
Contributor

Nice. It looks a lot better with the scrollbar at the border of the dialog.

@larz0
Copy link
Member

larz0 commented Apr 30, 2014

thumbs-up

@larz0 larz0 removed their assignment May 1, 2014
@larz0
Copy link
Member

larz0 commented May 1, 2014

UX review done.

@JeffryBooher
Copy link
Contributor

Looks good...Merging

JeffryBooher added a commit that referenced this pull request May 2, 2014
@JeffryBooher JeffryBooher merged commit adbba96 into adobe:master May 2, 2014
@marcelgerber marcelgerber deleted the update-dialog-style branch May 2, 2014 20:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants