This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

[replace-across-files] Replace in Files#7809

Merged

njx merged 56 commits intonj/unify-find-uifrom nj/replace-on-disk

Jun 13, 2014

+5,769-1,480

Commits on Mar 3, 2014

Refactors the search results to be able to use paging in Replace All
TomMalbran
committed

Commits on Apr 30, 2014

Make regexp searches multiline in FindInFiles to match single-file behavior
Narciso Jaramillo
committed

Commits on May 2, 2014

Commits on May 5, 2014

Implement basic textual find/replace in files
Narciso Jaramillo
committed

Commits on May 6, 2014

Don't replace on disk if the file has changed since we searched it
Narciso Jaramillo
committed
Add test for gracefully handling write failure
Narciso Jaramillo
committed
Do replacements in memory for files that are already open
Narciso Jaramillo
committed
Add way to force replacements to be done in memory instead of on disk
Narciso Jaramillo
committed

Commits on May 7, 2014

Handle regexp replacement
Narciso Jaramillo
committed
Start hooking up Replace in Files UI
Narciso Jaramillo
committed
Tweak Find Bar to only show Replace All... and relayout in replace-across-files case
Narciso Jaramillo
committed

Commits on May 8, 2014

Add logic to force in-memory replacements for 10 or fewer files, and add confirmation dialog. Clean up some unnecessary runs() in tests.
Narciso Jaramillo
committed
Add simple unit test for Replace All checkboxes
Narciso Jaramillo
committed
Add unit tests for paging Find in Files results
Narciso Jaramillo
committed
Merge from tom/search-results
Narciso Jaramillo
committed
Use batchOperation() instead of edit op merging for replace all
Narciso Jaramillo
committed

Commits on May 9, 2014

Integrate results panel with Replace in Files
Narciso Jaramillo
committed
Remove search panel templates that are no longer used
Narciso Jaramillo
committed
Improve Enter key behavior in Replace in Files
Narciso Jaramillo
committed
Tweak labels for batch replace buttons in both single and multi-file find/replace
Narciso Jaramillo
committed
Tweak layout of Find bar for find/replace across files
Narciso Jaramillo
committed
Disable Replace button when query is blank or invalid
Narciso Jaramillo
committed
Automatically open a changed file if current editor hasn't been changed by a Replace in Files operation
Narciso Jaramillo
committed
Use original line endings when comparing in-memory doc to known goods in Replace in Files unit tests
Narciso Jaramillo
committed

Commits on May 10, 2014

Bump up in-memory replace limit to 20. Tweak dialog to show the limit.
Narciso Jaramillo
committed
Ignore unchecked matches when computing number of files to replace in. Clone results so they don't get updated during the replace.
Narciso Jaramillo
committed
Beginning of refactoring to unify view code:
Narciso Jaramillo
committed
Rename resultsModel to searchModel since it has other stuff besides results
Narciso Jaramillo
committed
Clean up some global state in FindInFiles that can just use the search model
Narciso Jaramillo
committed
Just reverse the matches instead of sorting them in reverse since they're already in document order
Narciso Jaramillo
committed
Fix summary display
Narciso Jaramillo
committed
Remove unused var
Narciso Jaramillo
committed

Commits on May 12, 2014

Make single-file Replace All just use Find in Files. Plus fixes:
Narciso Jaramillo
committed
Move the rest of the query-related globals into SearchModel
Narciso Jaramillo
committed

Commits on May 13, 2014

Refactor all UI code out of FindInFiles - this is now a pure engine class.
Narciso Jaramillo
committed
Merge branch 'nj/unify-find-ui' into nj/replace-on-disk
Narciso Jaramillo
committed
Re-add error log statement that got dropped
Narciso Jaramillo
committed

Commits on May 14, 2014

Cleanup and bugfixes for Replace in Files:
Narciso Jaramillo
committed
Make limit on found results much larger, and apply it to total number of matches as well as number of matches in a file
Narciso Jaramillo
committed
Move FindInFiles tests into a separate file
Narciso Jaramillo
committed
Remove unused parameter
Narciso Jaramillo
committed
Add error dialog if problems occur during replace. Add a few more unit tests and behavior for edge cases.
Narciso Jaramillo
committed

Commits on May 15, 2014

Added tests for panel closure. Need to fix a bug that causes one of the tests to fail.
Narciso Jaramillo
committed
Fixed bug in panel title. Simplified construction of summary area.
Narciso Jaramillo
committed
Tweak flaky unit test - seems to pass consistently now
Narciso Jaramillo
committed
Add unit test for find/replace in dirty document.
Narciso Jaramillo
committed

Commits on May 16, 2014

More Replace in Files unit test work:
Narciso Jaramillo
committed
Ensure that Find in Files panel closes when document is reverted on close
Narciso Jaramillo
committed
Directly include FindInFilesUI instead of FindInFiles, since the former now registers the commands
Narciso Jaramillo
committed
Make sure we propagate error from then()
Narciso Jaramillo
committed

Commits on Jun 3, 2014

Commits on Jun 4, 2014

Replace in Selected File/Folder in Find menu
redmunds
committed

Commits on Jun 13, 2014

Merge pull request #8029 from adobe/randy/replace-in
Narciso Jaramillo
committed