Danish language.. to the release branch this time.. #8237
Conversation
|
I've posted a link to this on a Danish news-site and requested reviews: http://newz.dk/forum/tagwall/review-af-dansk-oversaettelse-af-brackets-134128 So far I've gotten one, but fairly thorough review.. I will try to get as many improvements implemented as possible before tomorrow.. |
|
@bodhiBit That sounds great. If you can get this done by tomorrow, it will make it into the 0.41 release. |
| <p> | ||
| Som tilføjelse til alle de gode sager der er indbygget i Brackets, har vores store og voksende samfund af | ||
| udviklere skabt over hundrede udvidelser, som tilføjer nyttig funktionalitet. Hvis der er | ||
| noget du har brug for, som Brackets ikke tilbyder, er det ret sandsynigt at nogen har lavet en udvidelse til |
There was a problem hiding this comment.
sandsynigt? Did you mean: sandsynligt?
There was a problem hiding this comment.
oops.. missed that one.. fixed.. :)
|
@bodhiBit Thanks for your quick responses! I looked at the strings in google translate (http://translate.google.com) because we needed to know today if this was close enough to consider for Release 0.41 -- looks good to me. I will not merge it until tomorrow morning (my time) in case a native Danish speaker can give a more in-depth review and you want to make any more changes. |
| // Relative to the samples folder | ||
| "GETTING_STARTED" : "da/Kom godt i gang", | ||
| "ADOBE_THIRD_PARTY" : "http://www.adobe.com/go/thirdparty_da/", | ||
| "WEB_PLATFORM_DOCS_LICENSE" : "http://creativecommons.org/licenses/by/3.0/deed.da" |
There was a problem hiding this comment.
As @sbruchmann said, http://www.adobe.com/go/thirdparty_da/ redirects to http://www.adobe.com/dk/products/eula/third_party/ which is incorrect. This is because the Adobe EULA web site does not seem to have a translation for Danish, so remove the ADOBE_THIRD_PARTY line so that it defaults to root (English) translation.
There was a problem hiding this comment.
It looks like http://creativecommons.org/licenses/by/3.0/deed.da is also not translated, so remove that line as well.
| define({ | ||
| // Relative to the samples folder | ||
| "GETTING_STARTED" : "da/Kom godt i gang", | ||
| "WEB_PLATFORM_DOCS_LICENSE" : "http://creativecommons.org/licenses/by/3.0/deed.da" |
There was a problem hiding this comment.
I commented on the other thread right before your last update, so I'll post again to make sure you see this:
It looks like http://creativecommons.org/licenses/by/3.0/deed.da is also not translated, so remove that line as well.
|
I am done with my review. I'll wait until tomorrow morning to merge in case any other suggestions come in. |
|
I don't know if this have been merged yet or you are waiting for word from me.. The translations is pretty much done.. I've implemented any corrections I've received and proofread it multiple times.. It's ready to go.. |
|
Thanks. Merging. |
Danish language.. to the release branch this time..
As requested, I'm submitting my pull request to the release branch instead of master..
I will see if I can get some other danish guys (and gals) to review it..