This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fix a second infinite loop in CSSUtils.findSelectorAtDocumentPos() #9295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aused by cleanups in the fix for the earlier infinite loop bug. To keep loop exit condition more precisely in sync with TokenUtils's logic for when to stop advancing, create new TokenUtils methods for checking if at a stopping point.
|
Reviewing ... |
| @@ -76,6 +76,11 @@ define(function (require, exports, module) { | |||
| return true; | |||
| } | |||
|
|
|||
| /** Returns true if movePrevToken() would return false without changing pos */ | |||
|
Looks good! Just have minor nits for JSDoc. Ran all tests and it does fix the CSSUtils unit test failure. |
type annotations while I'm at it.
|
@RaymondLim Changes pushed. I fixed a bunch of other type annotations in that file at the same time, since it turned out many of the existing ones were inaccurate or had bad syntax. |
|
Looks good! Merging. |
RaymondLim
added a commit
that referenced
this pull request
Sep 25, 2014
Fix a second infinite loop in CSSUtils.findSelectorAtDocumentPos()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a second infinite loop in
CSSUtils.findSelectorAtDocumentPos(), caused by cleanups in the fix for the earlier infinite loop bug (#9002). To keep loop exit condition more precisely in sync with TokenUtils's logic for when to stop advancing, create new TokenUtils methods for checking if at a stopping point.The existing unit test
"should find the first selector when pos is at beginning of selector name"already hits the case that was broken here -- basically a curly brace that's not alone on a line, afaict -- so I didn't bother adding any additional unit tests in this PR.@RaymondLim @marcelgerber