This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Avoid "Debug > Open Brackets Source" hitting symlink bug #6692 #9399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of opening it in Brackets, to avoid opening a symlink path and hitting #6692.
|
Nominating for 0.44 since it's an easy fix to prevent the bug going into the wild. |
|
Change looks good. Tested on OSX 10.8 -- brackets folder opened in Finder |
This was causing a travis build failure
JeffryBooher
added a commit
that referenced
this pull request
Oct 2, 2014
Avoid "Debug > Open Brackets Source" hitting symlink bug #6692
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just spotted this... the new "Open Brackets Source" command added in #8859 is somewhat dangerous, because in developer setups it'll open a symlink alias to the actual git source tree. On Macs, this means hitting #6692 -- file watching stops working, but Brackets doesn't realize it and keeps caching files anyway. It's a fairly nasty bug to hit in a folder where you're quite likely to have external changes (e.g. git syncing).
Proposed fix here is to open the folder as an OS folder view instead of switching projects within Brackets. The original use case in #8795 (what #8859 was addressing) was just to be able to double-check where the 'set up for hacking' copy of the source is coming from, and I think this still covers that quite well. (Plus it avoids any potential confusion -- the first time I clicked it, it was surprising that I was getting prompted about unsaved changes, etc., since it's not obvious that the action includes closing your current project).