Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fail and retry logic when pushing images #103

Merged
merged 5 commits into from
Dec 12, 2023

Conversation

bluesliverx
Copy link
Contributor

@bluesliverx bluesliverx commented Dec 12, 2023

Description

This removes the multiprocessing from pushing images, which really isn't needed as we can fail other ways there.

Related Issue

Motivation and Context

I noticed failures when pushing multiple repos from a multiplatform build. Most concerning was that the build acted like everything was ok when it really failed to push at least one of the images.

How Has This Been Tested?

I've added a functional test file, though this doesn't completely exercise the code in question, it should be closer to what actually happens.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bluesliverx bluesliverx merged commit 9068605 into adobe:main Dec 12, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants