Improve fail and retry logic when pushing images #103
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the multiprocessing from pushing images, which really isn't needed as we can fail other ways there.
Related Issue
Motivation and Context
I noticed failures when pushing multiple repos from a multiplatform build. Most concerning was that the build acted like everything was ok when it really failed to push at least one of the images.
How Has This Been Tested?
I've added a functional test file, though this doesn't completely exercise the code in question, it should be closer to what actually happens.
Screenshots (if appropriate):
Types of changes
Checklist: