Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usages of union in config validation #86

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Fix usages of union in config validation #86

merged 1 commit into from
Oct 18, 2023

Conversation

bluesliverx
Copy link
Contributor

Description

This fixes duplicated None references when Optional will suffice.

Related Issue

Motivation and Context

Just making the code more pythonic (one right way to do things).

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bluesliverx bluesliverx changed the title Fix usgaes of union in config validation Fix usages of union in config validation Oct 18, 2023
@bluesliverx bluesliverx merged commit de4708d into adobe:main Oct 18, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobtruman jacobtruman jacobtruman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bluesliverx @jacobtruman