Bugfix for intermittent multi-platform build failures #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluesliverx
reviewed
Oct 27, 2023
| file (str): The path/name of the Dockerfile (ie. <path>/Dockerfile). | ||
| tags (List[str]): The tags to apply to the image. | ||
| docker_registry (str): The docker registry to push the image to. | ||
| mp_image_name (str): A list of built images. |
There was a problem hiding this comment.
How is a single string a list of images?
bluesliverx
reviewed
Oct 27, 2023
| self._intermediate_built_images[mp_image_name].append(ImageInfo(repo=name, | ||
| tags=tags, | ||
| platform=platform, | ||
| digest=image_id,)) |
There was a problem hiding this comment.
IMHO, I think reading heavily indented lines is difficult and makes it harder to improve change things later on (i.e. adding another parameter, etc). I usually prefer this style:
self._intermediate_built_images[mp_image_name].append(ImageInfo(
repo=name,
tags=tags,
platform=platform,
digest=image_id,
))
This is 100% my personal preference though, so I thought I'd bring it up as an alternative just in case you might like it better too? No worries on changing it if you prefer it this way though, seriously.
There was a problem hiding this comment.
I do like it better this way. I updated this with a new commit.
bluesliverx
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bugfix for intermittent multi-platform build failures
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: