Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use load instead of push to support remote builders #94

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

bluesliverx
Copy link
Contributor

@bluesliverx bluesliverx commented Nov 8, 2023

Description

Adds support for building on remote builders that cannot access the local registry.

Related Issue

Motivation and Context

When using remote builders, they cannot access the temporary local registry since it runs on localhost. Attempting to do with fully qualified names is also problematic unless we set up full certs, auth, etc. To prevent this, we can simply --load instead of --push'ing in the buildx build, then push the resulting image for the final manifest creation.

How Has This Been Tested?

I tested this in a development environment to ensure it does as expected.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bluesliverx bluesliverx merged commit b8e8102 into adobe:main Nov 9, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants