Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and add additional tests for mp building #95

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

bluesliverx
Copy link
Contributor

@bluesliverx bluesliverx commented Nov 9, 2023

Description

This removes the push flag that was never unset when building multiplatform images. It also adds some testing to ensure that things are working correctly in mocking.

Related Issue

Motivation and Context

Simplification and better testing was desired.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bluesliverx bluesliverx merged commit 11934af into adobe:main Nov 9, 2023
8 checks passed
@bluesliverx bluesliverx deleted the mp-load branch November 10, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants