Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent no resource to delete error #96

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Conversation

bluesliverx
Copy link
Contributor

Description

The current release of buildrunner shows an error when building multiplatform images. This error is ignored and everything works fine, it just makes people think that something actually went wrong. This fixes that.

Related Issue

Motivation and Context

The error is related to trying to cleanup images that were built. Since multiplatform images are built differently than single platform images and cleaned up differently as well, we just need to not do the code that handles cleaning up images when building multiplatform.

How Has This Been Tested?

I tested this manually on a build agent.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bluesliverx bluesliverx merged commit 532cac6 into adobe:main Nov 10, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants