Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable user defined port and proto for metrics http listener #23

Merged
merged 15 commits into from
Sep 6, 2018

Conversation

matthsmi
Copy link
Collaborator

@matthsmi matthsmi commented Sep 5, 2018

Currently port is statically set to :8080. That doesn't work for everyone.

Make it so that in the globals you can specify the the listening port, and the protocol.
If it's http, should be simple. If it's https, then require some tls bits.

@matthsmi
Copy link
Collaborator Author

matthsmi commented Sep 6, 2018

Done a few things here.

  • added the http-proto / http-port / http-tls-cert / http-tls-key [global] configuration options.
  • tweaked the monitor listener to bind to either non tls or tls ports based upon aforementioned configuration options.
  • added some tests against that change
  • updated base docker image to alpine3.8 and golang 1.11.0
  • shuffled some stuff around (eg: alog/ -> internal/alog/ , stats/ -> internal/stats/). Hoping to do some more cleanup of that soon.
  • updated it all so building/testing works again.

@matthsmi matthsmi merged commit 52a7268 into master Sep 6, 2018
@matthsmi matthsmi deleted the issue_22 branch September 6, 2018 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant