Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): add full typedefs and esm support #196

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

maxakuru
Copy link
Member

@maxakuru maxakuru commented Jul 28, 2021

diff makes this look larger than it is.. really it's 2 things:

Types:

  • add types key to package.json
  • move index.d.ts into api.d.ts (so we can reference the entire api namespace when creating a new context)
  • add some extra types that weren't exported

ESM:

  • add index.mjs with named exports for each cjs export that already existed, +1 additional export to match the types that were already defined (ALPNProtocols)
  • add exports key to package.json (referencing the module above)

@maxakuru maxakuru merged commit 0859cd3 into adobe:main Jul 29, 2021
github-actions bot pushed a commit that referenced this pull request Jul 29, 2021
# [2.4.0](v2.3.0...v2.4.0) (2021-07-29)

### Features

* **types:** add full typedefs and esm support ([#196](#196)) ([0859cd3](0859cd3))
@github-actions
Copy link

🎉 This PR is included in version 2.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants