Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new pipeline and htlengine for full jsdom support #954

Closed
tripodsan opened this issue Jun 6, 2019 · 1 comment
Closed

use new pipeline and htlengine for full jsdom support #954

tripodsan opened this issue Jun 6, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request released

Comments

@tripodsan
Copy link
Contributor

The improved pipeline now only uses JSDOM. The DOM supporting htlengine can directly use the prepared document thus avoiding to/from HTML serialization roundtrips.

Note the breaking changes:

BREAKING CHANGES:

  • remove htast from context.content schema
  • remove hast from context.response schema
  • add document from to context.response schema
  • context.htast and context.response.hast is no longer generated
  • mdast to jsdom transformation handlers can only return hast (not string, not vdom)
  • html postprocessing pipeline step was renamed from hast to post
  • mixing inline html and markdown no longer works (eg: <em>This is **strong**</em>)

@tripodsan tripodsan added the enhancement New feature or request label Jun 6, 2019
@tripodsan tripodsan self-assigned this Jun 6, 2019
tripodsan added a commit that referenced this issue Jun 6, 2019
fixes #954

BREAKING CHANGES:
  - remove htast from context.content schema
  - remove hast from context.response schema
  - add document from to context.response schema
  - context.htast and context.response.hast is no longer generated
  - mdast to jsdom transformation handlers can only return hast (not string, not vdom)
  - html postprocessing pipeline step was renamed from hast to post
  - mixing inline html and markdown no longer works (eg: <em>This is **strong**</em>)
tripodsan added a commit that referenced this issue Jun 6, 2019
fixes #954

BREAKING CHANGES:
  - remove htast from context.content schema
  - remove hast from context.response schema
  - add document from to context.response schema
  - context.htast and context.response.hast is no longer generated
  - mdast to jsdom transformation handlers can only return hast (not string, not vdom)
  - html postprocessing pipeline step was renamed from hast to post
  - mixing inline html and markdown no longer works (eg: <em>This is **strong**</em>)
tripodsan added a commit that referenced this issue Jun 6, 2019
fixes #954

BREAKING CHANGES: remove htast from context.content schema
BREAKING CHANGES: remove hast from context.response schema
BREAKING CHANGES: context.htast and context.response.hast is no longer generated
BREAKING CHANGES: mdast to jsdom transformation handlers can only return hast (not string, not vdom)
BREAKING CHANGES: html postprocessing pipeline step was renamed from hast to post
BREAKING CHANGES: mixing inline html and markdown no longer works (eg: <em>This is **strong**</em>)
@kptdobe kptdobe closed this as completed in 187287d Jun 6, 2019
trieloff pushed a commit that referenced this issue Jun 6, 2019
# [4.2.0](v4.1.0...v4.2.0) (2019-06-06)

### Features

* **pipeline:** use new pipeline and htlengine for full jsdom support ([187287d](187287d)), closes [#954](#954)
@adobe-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 4.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

No branches or pull requests

2 participants