Auto-Deployment (without Static Delivery Changes) #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/deploy.js
# Conflicts: # test/testDeployCmd.js
# Conflicts: # test/testDeployCmd.js
# Conflicts: # test/testUpCmd.js
Codecov Report
@@ Coverage Diff @@
## master #152 +/- ##
==========================================
+ Coverage 82.24% 82.83% +0.59%
==========================================
Files 21 22 +1
Lines 1098 1177 +79
Branches 125 142 +17
==========================================
+ Hits 903 975 +72
- Misses 195 202 +7
Continue to review full report at Codecov.
|
|
This pull request introduces 1 alert when merging 5870dec into e707ff1 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
|
thanks @trieloff for squashing the 24 commits :-) really appreciate! |
tripodsan
pushed a commit
that referenced
this pull request
Sep 6, 2018
- fixes #135 * Refactor: create GitUtils utility class * added --circleci-auth option for hlx deploy --auto #135 * follow project on CircleCI #135 * Set build environment variables #135 * hlx deploy now requires fastly, wsk, and circleci settings * check for existence of config.yml before starting auto-deployment * Actually pass fastly parameters into command executor * Added default CircleCI configs * fix test * bring up test coverage * Don't log fastly auth * added integration test (with fixtures) for auto-deploy * lint * restore state after testing * lint * fix tests * Resolve conflicts * fix lint * fix failing test * fix another failing test * Fix for deploy command test failure * increase timeouts * fix linting errors * revert partial refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #135 and obsoletes #130. It does no longer have a dependency on #112, as this might take a bit longer to be discussed.
The default for
hlx deployishlx deploy --auto, which will set up a CI/CD pipeline for the given repository. To do this, we depend on:(this branch is based on both branches to avoid later merge conflicts)
The rough process will look like this:
hlx deploygets a--circleci-authoptionscurl -X "POST" "https://circleci.com/api/v1.1/project/github/trieloff/helix-helpx/follow"curl -X "POST" "https://circleci.com/api/v1.1/project/github/trieloff/helix-helpx/envvar" -H 'Accept: application/json' -H 'Content-Type: application/json' -d $'{"name": "HLX_WSK_AUTH","value": "FOO"}'(repeat for all arguments that are relevant tohlx deployandhlx strain).circleci/config.yaml