Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto publish gh release on version tag #331

Merged
merged 2 commits into from
Nov 19, 2018
Merged

auto publish gh release on version tag #331

merged 2 commits into from
Nov 19, 2018

Conversation

stefan-guggisberg
Copy link
Contributor

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues

#306

Thanks for contributing!

@codecov
Copy link

codecov bot commented Nov 17, 2018

Codecov Report

Merging #331 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #331   +/-   ##
=======================================
  Coverage   77.12%   77.12%           
=======================================
  Files          28       28           
  Lines        1460     1460           
  Branches      220      220           
=======================================
  Hits         1126     1126           
  Misses        334      334

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f200ac1...b2db0da. Read the comment docs.

@stefan-guggisberg
Copy link
Contributor Author

@tripodsan @trieloff the 'auto gh release' is triggered by a new version tag (v1.2.3). any idea how i can test this without messing with tags and releases?

Copy link
Contributor

@tripodsan tripodsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, but I think the checkout is not needed.

.circleci/config.yml Show resolved Hide resolved
@tripodsan
Copy link
Contributor

the 'auto gh release' is triggered by a new version tag (v1.2.3). any idea how i can test this without messing with tags and releases?

maybe create tags manually by using a special tag, like: v99.3.1

@stefan-guggisberg stefan-guggisberg merged commit 117dda2 into master Nov 19, 2018
@trieloff
Copy link
Contributor

Or just mess with it, and then clean up later ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants