Fix static 404

[tripodsan]

see #591

also adds action name to trace for better debugging of the request chain.

[codecov]

Codecov Report

Merging #593 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #593   +/-   ##
=======================================
  Coverage   85.41%   85.41%           
=======================================
  Files          39       39           
  Lines        1961     1961           
  Branches      300      300           
=======================================
  Hits         1675     1675           
  Misses        286      286

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b338328...7d4192f. Read the comment docs.

[codecov]

Codecov Report

Merging #593 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #593   +/-   ##
=======================================
  Coverage   85.41%   85.41%           
=======================================
  Files          39       39           
  Lines        1961     1961           
  Branches      300      300           
=======================================
  Hits         1675     1675           
  Misses        286      286

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b338328...7d4192f. Read the comment docs.

[trieloff]

Ideally, we would cache the 404 coming from the static action, right?

[tripodsan]

Ideally, we would cache the 404 coming from the static action, right?

yes, but not from the html action. I wouldn't invest too much here, as the refactored VCL works quite different. and, as I mentioned elsewhere, it would probably be better to only have 1 action that handles everything ;-)

[ejthurgo]

It's common to cache 404s, but usually quite short lifespans compared to 2XX so perhaps explicitly specify a shorter TTL.
But I'm tempted to agree with Tobias, maybe worth waiting until the new VCL merges.

[trieloff]

Ok, I'm merging this, but putting it on the adobe/helix-publish#7 post-merge todo list.