Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template): clean up x-error header value prior to sending response #202

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

trieloff
Copy link
Contributor

@trieloff trieloff commented Apr 7, 2021

see #201 (not a complete fix)

@github-actions
Copy link

github-actions bot commented Apr 7, 2021

This PR will trigger a patch release when merged.

@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #202 (2e03414) into main (1adc8a6) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
+ Coverage   85.03%   85.05%   +0.01%     
==========================================
  Files          20       20              
  Lines        1397     1398       +1     
==========================================
+ Hits         1188     1189       +1     
  Misses        209      209              
Impacted Files Coverage Δ
src/template/index.js 92.24% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cecdba...2e03414. Read the comment docs.

@trieloff trieloff merged commit f97c521 into main Apr 7, 2021
@trieloff trieloff deleted the cleanup-x-error-header branch April 7, 2021 09:15
@github-actions
Copy link

github-actions bot commented Apr 7, 2021

🎉 This PR is included in version 3.18.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants