Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Removing awsLayers does not remove layers from a deployed function #735

Merged
merged 1 commit into from
Sep 6, 2024
Merged

fix: Removing awsLayers does not remove layers from a deployed function #735

merged 1 commit into from
Sep 6, 2024

Conversation

alexkli
Copy link
Contributor

@alexkli alexkli commented Sep 6, 2024

Description

Fixes #734. Always set Layers to an array, even if awsLayers is not configured.

How Has This Been Tested?

Manually verified that setting an empty Layers array on Lambda will overwrite and remove any previously set layers.

Added 3 new unit tests for cases

  • no awsLayers set
  • awsLayers with 1 layer
  • awsLayers with 2 layers

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tripodsan tripodsan merged commit b2bb82b into main Sep 6, 2024
5 checks passed
@tripodsan tripodsan deleted the remove-layer branch September 6, 2024 08:30
adobe-bot pushed a commit that referenced this pull request Sep 6, 2024
@semantic-release-bot
chore(release): 12.1.1 [skip ci]
08889f7 
## [12.1.1](v12.1.0...v12.1.1) (2024-09-06)

### Bug Fixes

* Removing awsLayers does not remove layers from a deployed function [#734](#734) ([#735](#735)) ([b2bb82b](b2bb82b))
@adobe-bot
Copy link

🎉 This PR is included in version 12.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@alexkli
Copy link
Contributor Author

alexkli commented Sep 6, 2024

Thanks @tripodsan 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tripodsan tripodsan tripodsan approved these changes

@justinedelson justinedelson Awaiting requested review from justinedelson

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removing awsLayers does not remove layers from a deployed function
3 participants
@alexkli @adobe-bot @tripodsan