Bring Test Coverage up to 100% (#152)

* remove unccessary code block

* increase test coverage for type matcher

* bring up test coverage of image handler

* better coverage reporting

* bring up test coverage

* remove dead code

.gitignore

@@ -3,3 +3,4 @@ pipeline.log
 logs/pipeline.log
 .nyc_output
 logs/debug
+coverage

.npmignore

@@ -7,3 +7,4 @@
 adobe-helix-*
 logs
 test
+coverage

package.json

@@ -6,7 +6,7 @@
   "main": "index.js",
   "types": "index.d.ts",
   "scripts": {
-    "test": "nyc mocha --exit",
+    "test": "nyc nyc --reporter=lcov mocha --exit",
     "lint": "npx eslint . && npm run types",
     "types": "npm run docs && node bin/schema2ts.js",
     "docs": "npx jsonschema2md -d src/schemas -o docs",

src/html/output-debug.js

@@ -23,12 +23,6 @@ function debug(payload, { logger }) {
     // and causes rendering issues of the script
     delete p.response.body;
 
-    if (p.content && p.content.document && p.content.document.innerHTML) {
-      // document is a 'live' document, so turn it into a nice HTML string
-      const html = p.content.document.innerHTML;
-      p.content.document = html;
-    }
-
     const debugScript = DEBUG_TEMPLATE.replace(/PAYLOAD_JSON/, JSON.stringify(p));
     // inject debug script before the closing body tag
     p.response.body = body.replace(/<\/body>/i, `${debugScript}</body>`);

src/pipeline.js

@@ -199,9 +199,7 @@ class Pipeline {
    */
   error(f) {
     this.describe(f);
-    if (!this._last) {
-      this._last = this._pres;
-    }
+
     const wrapped = errorWrapper(f);
     // ensure proper alias
     wrapped.alias = f.alias;

src/utils/image-handler.js

@@ -16,17 +16,13 @@ const url = require('uri-js');
 
 /**
  * Creates an array of widths based on a set of options
- * @param {(object|number[])} options either an array of sizes or a set of parameters
+ * @param {object} options a set of parameters
  * to generate an array of options
  * @param {number} options.from smallest possible size
  * @param {number} options.to largest possible size
  * @param {number} options.steps number of steps
  */
 function makewidths(options) {
-  if (Array.isArray(options)) {
-    return options;
-  }
-
   const { from, to } = options;
   const range = to - from;
   const steps = Math.max(2, options.steps);
@@ -40,7 +36,7 @@ function image({
   IMAGES_MAX_SIZE,
   IMAGES_SIZE_STEPS,
   IMAGES_SIZES,
-} = {}) {
+}) {
   const widths = {
     from: parseInt(IMAGES_MIN_SIZE, 10),
     to: parseInt(IMAGES_MAX_SIZE, 10),

test/testPipeline.js

@@ -137,7 +137,7 @@ describe('Testing Pipeline', () => {
       .catch(done);
   });
 
-  it('When works with promises pre before when', (done) => {
+  it('When works with promises resolving false pre before when', (done) => {
     const order = [];
     new Pipeline({ logger })
       .before(() => { order.push('pre0'); })
@@ -155,6 +155,25 @@ describe('Testing Pipeline', () => {
       .catch(done);
   });
 
+
+  it('When works with promises resolving true pre before when', (done) => {
+    const order = [];
+    new Pipeline({ logger })
+      .before(() => { order.push('pre0'); })
+      .before(() => { order.push('enabled'); })
+      .when(() => Promise.resolve(true))
+      .before(() => { order.push('pre1'); })
+      .once(() => { order.push('once'); })
+      .after(() => { order.push('post0'); })
+      .after(() => { order.push('post1'); })
+      .run()
+      .then(() => {
+        assert.deepEqual(order, ['pre0', 'enabled', 'pre1', 'once', 'post0', 'post1']);
+        done();
+      })
+      .catch(done);
+  });
+
   it('Disables post before when', (done) => {
     const order = [];
     new Pipeline({ logger })

test/testTypeMatcher.js

@@ -23,6 +23,9 @@ describe('Test Type Matcher Util', () => {
     assert.deepEqual(new TypeMatcher(null).process(), []);
     assert.deepEqual(new TypeMatcher().process(), []);
     assert.deepEqual(new TypeMatcher([]).process(), []);
+    assert.deepEqual(new TypeMatcher([
+      { type: 'root' },
+    ]).process(), { type: 'root', types: [] });
   });
 
   it('TypeMatcher returns empty array if no matchers are registered', () => {