context.request.path & context.request.url are incorrect for subdirectory strains

[stevengill]

Related to adobe/helix-simulator#186.

I believe the context.request.path and context.request.url variables need to be updated to handle subdirectories.

Example Strain

  - name: contributor-docs-helixdemo
    <<: *basestrain
    url: https://adobedevsite.helix-demo.xyz/contributor/docs
    content: https://github.com/AdobeDocs/contributor.en.git/help#master
    directoryIndex: introduction.html
    package: developer-adobe-com/756ec092f2585c73ef0b75ba1caf8a698091d44a

variable values:

• context.request.path = /contributor/docs/help/introduction.html
• context.request.url = /contributor/docs/help/introduction.html
• action.request.params.path = /help/introduction.md
• action.request.params.rootPath = /contributor/docs

I believe the context.request.path/url should be /contributor/docs/introduction.html. action.request.params.path might also be wrong. Not sure if it should include the /help part.

[tripodsan]

correct. I think that the request.path and request.url should always be the one that is requested.

I think the problem is similar to HttpServletRequest.getPathInfo() in java. so we should probably add this.

so for a request to /contributor/docs/introduction.html above, it should yield:

property	value
context.request.path	/contributor/docs/introduction.html
context.request.rootPath1	/contributor/docs
context.request.pathInfo	/introduction.html
action.request.params.path	/help/introduction.md
(action.request.params.contentRoot)2	/help

¹ I would move/duplicate this in the context.request for consistency
² What's missing completely is the path of the repository mount. so maybe we need to add this, too

[tripodsan]

quick fix would be to use the action.params.headers['x-old-url'] as request.path and x-repo-root-path for contentRoot, but probably better to include contentRoot and/or pathInfo directly in the action params.

@trieloff WDYT?

[tripodsan]

if the request to a directory, the request.path should also be the original one:

request to /contributor/docs/ with the strain above above, should yield:

property	value
context.request.path	/contributor/docs/
context.request.rootPath	/contributor/docs
context.request.pathInfo	'' (empty string)
action.request.params.path	/help/introduction.md
action.request.params.contentRoot	/help

[trieloff]

🎉 This issue has been resolved in version 1.3.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀