Skip to content
This repository has been archived by the owner on Feb 28, 2022. It is now read-only.

Disable XSS sanitizer by default #356

Closed
tripodsan opened this issue Jun 5, 2019 · 3 comments · Fixed by #358
Closed

Disable XSS sanitizer by default #356

tripodsan opened this issue Jun 5, 2019 · 3 comments · Fixed by #358
Assignees
Labels

Comments

@tripodsan
Copy link
Contributor

Allowing HTML in markdown voids the need to a XSS sanitizer a little bit.
Suggest to disable it by default. either by removing it from the html pipeline completely, or safeguard it with:

    .before(sanitize).when(paranoid)

/cc @trieloff @davidnuescheler @ramboz

@rofe
Copy link
Contributor

rofe commented Jun 5, 2019

Agreed. And having to remember to use

  ${content.document.body.innerHTML @ context = 'unsafe'}

in html.htl is error prone and kind of ugly...

@tripodsan
Copy link
Contributor Author

tripodsan commented Jun 6, 2019

Agreed. And having to remember to use

  ${content.document.body.innerHTML @ context = 'unsafe'}

in html.htl is error prone and kind of ugly...

this was reverted with the new htlengine #337

tripodsan added a commit that referenced this issue Jun 6, 2019
tripodsan added a commit that referenced this issue Jun 6, 2019
adobe-bot pushed a commit that referenced this issue Jun 6, 2019
# [2.5.0](v2.4.0...v2.5.0) (2019-06-06)

### Features

* **html-pipe:** disable sanitizer by default ([876b743](876b743)), closes [#356](#356)
@adobe-bot
Copy link

🎉 This issue has been resolved in version 2.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants