Skip to content
This repository has been archived by the owner on Feb 28, 2022. It is now read-only.

npm tests fail when offline #64

Closed
tripodsan opened this issue Oct 5, 2018 · 5 comments
Closed

npm tests fail when offline #64

tripodsan opened this issue Oct 5, 2018 · 5 comments
Labels
bug Something isn't working

Comments

@tripodsan
Copy link
Contributor

the npm tests read github to tests the markdown parsing. when working offline, the tests fail.
@tripodsan tripodsan added the bug Something isn't working label Oct 5, 2018
@trieloff
Copy link
Contributor

trieloff commented Oct 8, 2018

Would you rather:

  • mock GitHub
  • exclude tests with network activity from unit testing?

@tripodsan
Copy link
Contributor Author

Why not use replay?

@trieloff
Copy link
Contributor

trieloff commented Oct 9, 2018

Ok, so we just mock it using Replay. Makes the tests more robust to content changes in that repo, too.

@trieloff
Copy link
Contributor

I found another way: we can check for connectivity, and skip the test when offline.

trieloff added a commit that referenced this issue Dec 19, 2018
@trieloff
more tests, still failing when offline #64
6bde173
@trieloff trieloff mentioned this issue Dec 19, 2018
Merged
trieloff added a commit that referenced this issue Dec 19, 2018
@trieloff
Offline tests (#149) - supporting #64
62b38c5 
* Offline tests with Polly

* more tests, still failing when offline #64

* try modifying recording

* lint

* HTML recordings #62

* recordings for JSON #62

* XML recordings #62

* lint

* exit tests
@kptdobe
Copy link
Contributor

kptdobe commented Mar 26, 2019

Just tested, tests work offline.

@kptdobe kptdobe closed this as completed Mar 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@trieloff @kptdobe @tripodsan