This repository has been archived by the owner on Feb 28, 2022. It is now read-only.
Rewrite Static Asset References to ESI #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `script.js.esi` or `style.css.esi` resource will be replaced with a long-cacheable URL implements #267
…ide stable URLs When run in production, all `<script src>` and `<link href>` references pointing to external assets will be rewritten to become ESI includes of the same URL, with an added extension that can be resolved into a stable URL Fixes #224
Codecov Report
@@ Coverage Diff @@
## master #281 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 42 45 +3
Lines 916 949 +33
=====================================
+ Hits 916 949 +33
Continue to review full report at Codecov.
|
This was referenced Apr 24, 2019
HTML response bodies will now be parsed and then serialized before the final response is created. This creates the opportunity of changing the HTML AST for HTML-post-processing Fixes #285
trieloff
added a commit
to adobe/helix-cli
that referenced
this pull request
Apr 29, 2019
… tests helps with failing smoke tests for adobe/helix-pipeline#281
Merged
|
🎉 This PR is included in version 1.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial implementation of #224, but depends on:
*.css.esirequestsAlso fixes #285