This repository has been archived by the owner on Feb 28, 2022. It is now read-only.
feat(pipe): use jsdom everywhere #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tripodsan
force-pushed
the
jsdom
branch
2 times, most recently
from
5e3bc2c to
0b5cf22
Compare
This comment has been minimized.
This comment has been minimized.
tripodsan
commented
May 29, 2019
| .before(responsive) | ||
| // todo: responsive used to operate on the htast, therefore ignored if content.document was used | ||
| // todo: there is similar logic in the image-handler during jsdom creation.... | ||
| // .before(responsive) |
tripodsan
commented
May 29, 2019
| * THIS SOFTWARE. | ||
| */ | ||
|
|
||
| // This was copied from https://github.com/syntax-tree/hast-util-to-dom/blob/master/src/index.js |
There was a problem hiding this comment.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tripodsan
force-pushed
the
jsdom
branch
2 times, most recently
from
19843a7 to
ad72e5e
Compare
Codecov Report
@@ Coverage Diff @@
## master #349 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 47 47
Lines 1041 1059 +18
=====================================
+ Hits 1041 1059 +18
Continue to review full report at Codecov.
|
tripodsan
force-pushed
the
jsdom
branch
3 times, most recently
from
5d38943 to
9dc890c
Compare
|
@tripodsan Alright. I'll review this tomorrow |
adobe-bot
pushed a commit
that referenced
this pull request
Jun 6, 2019
# [2.3.0](v2.2.0...v2.3.0) (2019-06-06) ### Features * **pipe:** use jsdom everywhere ([#349](#349)) ([d0e25c3](d0e25c3))
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #337, see #336
Improvements
htastandhastwhere possiblemdasttohasttodom. before it used to create the jsdom via a html-string roundtrip.BREAKING CHANGES:
htastfromcontext.contentschemahastfromcontext.responseschemadocumentfrom tocontext.responseschemacontext.htastandcontext.response.hastis no longer generatedhasttopost<em>This is **strong**</em>)Further Work
I think that we should generate the jsdom directly from the
mdast. this would even speed up the transformation more. currently, there is no utility available for this. we would need to copy major parts of mdast-util-to-hast.