Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

id collisions #121

Closed
maxakuru opened this issue Nov 14, 2023 · 3 comments
Closed

id collisions #121

maxakuru opened this issue Nov 14, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@maxakuru
Copy link
Member

the current ID generation results in 1-2 character strings, ultimately leading to collisions
since web crypto has good support, maybe we can switch to using builtins for generating uuids, with a simple polyfill fallback

@maxakuru maxakuru added the bug Something isn't working label Nov 14, 2023
@trieloff
Copy link
Contributor

Collisions are ultimately acceptable, as long as the collision rate within a single day for a single site is less than one percent. Even though the IDs are completely random and not persisted in the browser, we don't want to give the impression that they could hide PII, so the shorter the better.

@davidnuescheler
Copy link

davidnuescheler commented Nov 17, 2023

i think that's great, i haven't thought about it that way. i would find it more intuitive (and consistent) if the id was a fixed (albeit short) length, i am thinking 4-6 characters. @trieloff thoughts?

@trieloff
Copy link
Contributor

Fixed length would be an improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants