Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: id collisions #122

Closed
wants to merge 1 commit into from
Closed

fix: id collisions #122

wants to merge 1 commit into from

Conversation

maxakuru
Copy link
Member

fix #121

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (12e0f05) 22.54% compared to head (8a2c38a) 21.10%.

Files Patch % Lines
src/index.js 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
- Coverage   22.54%   21.10%   -1.45%     
==========================================
  Files           1        1              
  Lines         102      109       +7     
==========================================
  Hits           23       23              
- Misses         79       86       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@trieloff trieloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As explained in #121, the collisions are not unintended or catastrophic, so I'd evaluate the PR based on:

  • is the overall code getting shorter?
  • do we send more entropy or less?
  • us browser support getting better?

@maxakuru maxakuru closed this Nov 15, 2023
@maxakuru maxakuru deleted the maxed/uuid branch July 25, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

id collisions
2 participants