Use Performance API to get response status and sample accordingly #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ekrem Doğan <ekremney@users.noreply.github.com>
kptdobe
approved these changes
Nov 8, 2024
adobe-bot
pushed a commit
that referenced
this pull request
Nov 8, 2024
# [2.9.0](v2.8.0...v2.9.0) (2024-11-08) ### Features * use Performance API to get response status and sample accordingly ([#224](#224)) ([7702404](7702404))
|
🎉 This PR is included in version 2.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved from fork to main repo
In cloud service depending on configuration we may not know the actual response status when injecting the RUM script, thus cannot determine if the 404 or standalone script should be included. This PR adds client-side code to determine the response status using the Performance API and trigger the 404 sampling when needed, effectively combining the 404 and standalone script into one.
The response code is read from the PerformanceNavigationTiming object. The responseStatus is supported by modern browsers except for Safari. As a fallback the ServerTiming object is inspected for a status property which is read from a server-timing header which needs to be injected by the server, e.g. in the CDN. This is also supported by Safari.