fix(config): bring up test coverage

src/NamedMapHandler.js

@@ -11,17 +11,14 @@
  */
 const NamedMapHandler = (keyname = 'name') => ({
   get: (target, prop) => {
-    if (prop === 'length') {
-      return Object.keys(target).length;
-    }
     const index = Number.parseInt(prop, 10);
     if (!Number.isNaN(index) && index >= 0) {
       const [key, value] = Object.entries(target)[index];
       const obj = value;
       obj[keyname] = key;
       return obj;
     }
-    return target[prop];
+    return prop === 'length' ? Object.keys(target).length : target[prop];
   },
 });
 exports.NamedMapHandler = NamedMapHandler;

src/NamedPairHandler.js

@@ -11,9 +11,6 @@
  */
 const NamedPairHandler = (keyname, valuename) => ({
   get: (target, prop) => {
-    if (prop === 'length') {
-      return Object.keys(target).length;
-    }
     const index = Number.parseInt(prop, 10);
     if (!Number.isNaN(index) && index >= 0) {
       const [key, value] = Object.entries(target)[index];
@@ -22,7 +19,7 @@ const NamedPairHandler = (keyname, valuename) => ({
       obj[valuename] = value;
       return obj;
     }
-    return target[prop];
+    return prop === 'length' ? Object.keys(target).length : target[prop];
   },
 });
 exports.NamedPairHandler = NamedPairHandler;

src/SchemaDerivedConfig.js

@@ -96,10 +96,6 @@ class SchemaDerivedConfig extends BaseConfig {
 
     return this._content;
   }
-
-  toJSON() {
-    return this._cfg;
-  }
 }
 
 module.exports = SchemaDerivedConfig;

src/schemas/fstab.schema.json

@@ -15,9 +15,16 @@
   "type": "object",
   "title": "FSTab (Mount Points)",
   "description": "Defines a mapping between mount points and source URLs. Mount points **must** start with a slash (`/`) but may not end with one.",
-  "patternProperties": {
-    "^/.*[^/]$": {
-      "$ref": "https://ns.adobe.com/helix/shared/mountpoint"
+  "properties": {
+    "mountpoints": {
+      "type": "object",
+      "patternProperties": {
+        "^/.*[^/]$": {
+          "$ref": "https://ns.adobe.com/helix/shared/mountpoint"
+        }
+      }
     }
-  }
+  },
+  "additionalProperties": false,
+  "required": ["mountpoints"]
 }

test/mountpoints.test.js

@@ -20,6 +20,12 @@ const MountConfig = require('../src/MountConfig');
 const SPEC_ROOT = path.resolve(__dirname, 'specs/mountconfigs');
 
 const tests = [
+  {
+    title: 'fails with a broken config',
+    config: 'broken.yaml',
+    result: null,
+    error: 'Error: data should NOT have additional properties, data should have required property \'mountpoints\'',
+  },
   {
     title: 'loads a theblog example',
     config: 'fstab.yaml',

test/specs/mountconfigs/broken.yaml

@@ -0,0 +1,2 @@
+mounts:
+  /: https://adobe.sharepoint.com/sites/TheBlog/Shared%20Documents/theblog?csf=1&e=8Znxth