Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Deprecation warnings should be shown just once per run #159

Merged
merged 1 commit into from
Oct 1, 2019
Merged

fix: Deprecation warnings should be shown just once per run #159

merged 1 commit into from
Oct 1, 2019

Conversation

dominique-pfister
Copy link
Contributor

fixes #158

@codecov
Copy link

codecov bot commented Sep 20, 2019 •
edited
Loading

Codecov Report

Merging #159 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #159      +/-   ##
==========================================
+ Coverage   99.66%   99.66%   +<.01%     
==========================================
  Files          17       17              
  Lines        1206     1209       +3     
  Branches      290      291       +1     
==========================================
+ Hits         1202     1205       +3     
  Misses          4        4
Impacted Files Coverage Δ
src/Strain.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51638f3...84238f4. Read the comment docs.

tripodsan
tripodsan reviewed Sep 20, 2019
View reviewed changes
Copy link
Contributor

@tripodsan tripodsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is correct... if the flag is module-global, then it will never show for other invocations with different strains.

right now we use the strain only in the helix-cli in a one-shot manner. so it might not be a problem. but maybe the flags should be stored in the cfg?

@dominique-pfister
Copy link
Contributor Author

dominique-pfister commented Sep 20, 2019 •
edited
Loading

I don't think this is correct... if the flag is module-global, then it will never show for other invocations with different strains.

That's what it should do: if you run the tests in this module, they'll use different strains, and the deprecation warnings should just be shown once for that run.

@trieloff
Copy link
Contributor

Showing the warning once per run looks right to me.

@dominique-pfister dominique-pfister merged commit 3f21b52 into master Oct 1, 2019
adobe-bot pushed a commit that referenced this pull request Oct 1, 2019
@semantic-release-bot
chore(release): 3.0.1 [skip ci]
46d3c18 
## [3.0.1](v3.0.0...v3.0.1) (2019-10-01)

### Bug Fixes

* Deprecation warnings should be shown just once per run ([#159](#159)) ([3f21b52](3f21b52))
@adobe-bot
Copy link

🎉 This PR is included in version 3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dominique-pfister dominique-pfister deleted the show_warnings_once branch November 1, 2019 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tripodsan tripodsan tripodsan left review comments

@trieloff trieloff trieloff approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecation warnings should be shown just once per run
4 participants
@dominique-pfister @trieloff @adobe-bot @tripodsan