Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Deprecation warnings should be shown just once per run #159

Merged
merged 1 commit into from
Oct 1, 2019
Merged

fix: Deprecation warnings should be shown just once per run #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/Strain.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,12 @@ const Condition = require('../src/Condition.js');
const utils = require('./utils.js');
const log = require('./log.js');

/**
* Flags indicating whether deprecation warning were shown.
*/
let urlOverridesCondition;
let urlIsDeprecated;

/**
* Strain
*/
Expand Down Expand Up @@ -51,10 +57,12 @@ class Strain {
this._condition = new Condition(cfg.condition || '');

if (cfg.url) {
if (cfg.condition) {
if (cfg.condition && !urlOverridesCondition) {
log.warn('Property url overrides property condition, use just a condition instead.');
} else {
urlOverridesCondition = 1;
} else if (!urlIsDeprecated) {
log.info('Property url is deprecated, use a condition instead.');
urlIsDeprecated = 1;
}
}

Expand Down