Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IndexConfig.getQuery() better defaults #243

Closed
tripodsan opened this issue Feb 13, 2020 · 1 comment · Fixed by #244
Closed

IndexConfig.getQuery() better defaults #243

tripodsan opened this issue Feb 13, 2020 · 1 comment · Fixed by #244
Assignees
@tripodsan
Labels
released

Comments

@tripodsan
Copy link
Contributor

Description

  • when requesting a query with no page, the default passed in the url should be either missing or 0.
  • when requesting a query with no query, the default passed in the url should be missing or empty string
@tripodsan tripodsan self-assigned this Feb 13, 2020
tripodsan added a commit that referenced this issue Feb 13, 2020
@tripodsan
fix(query): better defaults for query and pages
9e79858 
fixes #243
@tripodsan tripodsan mentioned this issue Feb 13, 2020
Merged
tripodsan added a commit that referenced this issue Feb 14, 2020
@tripodsan
fix(query): better defaults for query and pages
04da304 
fixes #243
adobe-bot pushed a commit that referenced this issue Feb 14, 2020
@semantic-release-bot
chore(release): 5.2.1 [skip ci]
42cc93b 
## [5.2.1](v5.2.0...v5.2.1) (2020-02-14)

### Bug Fixes

* **config:** guard against broken config (fixes [#242](#242)) ([f221102](f221102))
* **index:** guard against empty config (fixes [#241](#241)) ([fc733cb](fc733cb))
* **query:** better defaults for query and pages ([04da304](04da304)), closes [#243](#243)
@adobe-bot
Copy link

🎉 This issue has been resolved in version 5.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tripodsan tripodsan

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(query): better defaults for query and pages adobe/helix-shared
2 participants
@tripodsan @adobe-bot