Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect with %20 in URL not working #353

Closed
rofe opened this issue Aug 19, 2020 · 5 comments · Fixed by #354
Closed

Redirect with %20 in URL not working #353

rofe opened this issue Aug 19, 2020 · 5 comments · Fixed by #354
Assignees
Labels
bug Something isn't working released

Comments

@rofe
Copy link
Contributor

rofe commented Aug 19, 2020

@rofe rofe added the bug Something isn't working label Aug 19, 2020
@tripodsan
Copy link
Contributor

@rofe why should this redirect work, and why is this in helix-shared ?

@trieloff
Copy link
Contributor

  1. because the customer (for better or worse) wanted to make that redirect
  2. match(path) {
    if (this._from.test(path)) {
    return {
    url: path.replace(this._from, this._to),
    type: this.type,
    };
    }
    return null;
    }

@tripodsan
Copy link
Contributor

ah, I didn't notice this is in shared....

but what is entered in the excel table?

trieloff added a commit that referenced this issue Aug 20, 2020
allow (but ignore) hostnames, match spaces

fixes #353 #352
adobe-bot pushed a commit that referenced this issue Aug 20, 2020
## [7.10.1](v7.10.0...v7.10.1) (2020-08-20)

### Bug Fixes

* **redirects:** relax redirect from matching ([4ff7c27](4ff7c27)), closes [#353](#353) [#352](#352)
@adobe-bot
Copy link

🎉 This issue has been resolved in version 7.10.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@rofe
Copy link
Contributor Author

rofe commented Aug 20, 2020

but what is entered in the excel table?

source: /en/2020/08/17/redefining%20-he-digital-experience-for-creating-and-collaborating-on-learning-content.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants