Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: dynamic redirect can't copy with data in json response #445

Closed
tripodsan opened this issue Mar 3, 2021 · 1 comment · Fixed by #446
Closed

Regression: dynamic redirect can't copy with data in json response #445

tripodsan opened this issue Mar 3, 2021 · 1 comment · Fixed by #446
Assignees
@tripodsan
Labels
bug Something isn't working released

Comments

@tripodsan
Copy link
Contributor

Is your feature request related to a problem? Please describe.
when data-embed sends the JSON response, the actual list of redirects is in the data property of the toplevel object.
#437 broke this.
@tripodsan tripodsan self-assigned this Mar 3, 2021
@tripodsan tripodsan mentioned this issue Mar 3, 2021
Merged
@tripodsan tripodsan added the bug Something isn't working label Mar 3, 2021
tripodsan added a commit that referenced this issue Mar 3, 2021
@tripodsan
fix(redirect): fix dynamic redirects via json
0f56fa5 
fixes #445
@tripodsan tripodsan mentioned this issue Mar 3, 2021
Merged
tripodsan added a commit that referenced this issue Mar 3, 2021
@tripodsan
fix(redirect): fix dynamic redirects via json (#446)
2124b60 
fixes #445
adobe-bot pushed a commit that referenced this issue Mar 3, 2021
@semantic-release-bot
chore(release): 7.21.1 [skip ci]
0db40ba 
## [7.21.1](v7.21.0...v7.21.1) (2021-03-03)

### Bug Fixes

* **redirect:** fix dynamic redirects via json ([#446](#446)) ([2124b60](2124b60)), closes [#445](#445)
@adobe-bot
Copy link

🎉 This issue has been resolved in version 7.21.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tripodsan tripodsan

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(redirect): fix dynamic redirects via json adobe/helix-shared
2 participants
@tripodsan @adobe-bot