Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(redirect): fix dynamic redirects via json #446

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

tripodsan
Copy link
Contributor

fixes #445

Thanks for contributing!

@tripodsan tripodsan requested a review from trieloff March 3, 2021 09:29
@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #446 (0f56fa5) into main (8f38ece) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #446   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files          26       26           
  Lines        1251     1255    +4     
  Branches      286      287    +1     
=======================================
+ Hits         1235     1239    +4     
  Misses         16       16           
Impacted Files Coverage Δ
src/DynamicRedirect.js 98.14% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb63659...0f56fa5. Read the comment docs.

@tripodsan tripodsan merged commit 2124b60 into main Mar 3, 2021
@tripodsan tripodsan deleted the dynamic-redirects-fix branch March 3, 2021 11:15
adobe-bot pushed a commit that referenced this pull request Mar 3, 2021
## [7.21.1](v7.21.0...v7.21.1) (2021-03-03)

### Bug Fixes

* **redirect:** fix dynamic redirects via json ([#446](#446)) ([2124b60](2124b60)), closes [#445](#445)
@adobe-bot
Copy link

🎉 This PR is included in version 7.21.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: dynamic redirect can't copy with data in json response
3 participants