Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yaml parser problems with comments #55

Closed
tripodsan opened this issue Feb 25, 2019 · 2 comments · Fixed by #64
Closed

yaml parser problems with comments #55

tripodsan opened this issue Feb 25, 2019 · 2 comments · Fixed by #64
Assignees
@tripodsan
Labels
bug Something isn't working released

Comments

@tripodsan
Copy link
Contributor

tripodsan commented Feb 25, 2019 •
edited
Loading

Description
apparently, the position of comments can confuse the yaml parser.
see https://github.com/adobe/developer.adobe.com/commit/3624692853fa66cd907cbbdc3b7268adbc1ec02c

To Reproduce
see commit above.

Additional Context
according to https://yaml.org/spec/1.2/spec.html#id2780069,

Outside scalar content, comments may appear on a line of their own, independent of the indentation level. Note that outside scalar content, a line containing only white space characters is taken to be a comment line.

/cc @filmaj
@tripodsan tripodsan added the bug Something isn't working label Feb 25, 2019
@tripodsan tripodsan self-assigned this Feb 28, 2019
@tripodsan
Copy link
Contributor Author

see eemeli/yaml#91

tripodsan added a commit that referenced this issue Mar 11, 2019
@tripodsan
fix(config): Use latest yaml parser to fix bug with comments
b65774c 
fix #55
@tripodsan tripodsan mentioned this issue Mar 11, 2019
Merged
tripodsan added a commit that referenced this issue Mar 11, 2019
@tripodsan
fix(config): Use latest yaml parser to fix bug with comments (#64)
2728234 
fix #55
tripodsan pushed a commit that referenced this issue Mar 11, 2019
@semantic-release-bot
chore(release): 0.8.1 [skip ci]
d84d778 
## [0.8.1](v0.8.0...v0.8.1) (2019-03-11)

### Bug Fixes

* **config:** Use latest yaml parser to fix bug with comments ([#64](#64)) ([2728234](2728234)), closes [#55](#55)
@trieloff
Copy link
Contributor

🎉 This issue has been resolved in version 0.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tripodsan tripodsan

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(config): Use latest yaml parser to fix bug with comments adobe/helix-shared
2 participants
@trieloff @tripodsan