condition languages: rules treated as properties might lead to ugly trees

[tripodsan]

the current schema defines the condition values as properties:

helix-shared/src/schemas/conditions.schema.json

Line 45 in fa56cd9

"patternProperties": {

which would lead to ugly trees for alternatives:

conditions:
  or:
    url.hostname=: www.adobe.com
    or:
       url.hostname=: www.adobe.io
       or:
         url.hostname=: www.adobe.net

of course, it could be written in a regexp, so maybe this is not really a problem

conditions:
   url.hostname~: www.adobe.(com|io|net)

an alternative could be to define the or, and nodes as arrays:

conditions:
  - or:
     - url.hostname=: www.adobe.com
     - url.hostname=: www.adobe.io
     - url.hostname=: www.adobe.net

or maybe both should be possible?

[trieloff]

or is an array. Your example should look like this:

conditions:
  or:
    - url.hostname=: www.adobe.com
   - url.hostname=: www.adobe.io
   - url.hostname=: www.adobe.net

[tripodsan]

@trieloff but then, those are wrong:

helix-shared/test/specs/configs/valid-conditions.yaml

Line 52 in 6eaad4f

and: