Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid "and" and "or" expressions are interpreted as valid. #96

Closed
trieloff opened this issue Apr 24, 2019 · 4 comments · Fixed by #97
Closed

Invalid "and" and "or" expressions are interpreted as valid. #96

trieloff opened this issue Apr 24, 2019 · 4 comments · Fixed by #97
Labels
bug Something isn't working released

Comments

@trieloff
Copy link
Contributor

@trieloff but then, those are wrong:

helix-shared/test/specs/configs/valid-conditions.yaml

Line 52 in 6eaad4f

and:

Originally posted by @tripodsan in #94 (comment)
@trieloff trieloff added the bug Something isn't working label Apr 24, 2019
@trieloff
Copy link
Contributor Author

Yes, looks like a bug.

@dominique-pfister dominique-pfister changed the title Invalid and and or expressions are interpreted as valid. Invalid "and" and "or" expressions are interpreted as valid. Apr 24, 2019
@dominique-pfister
Copy link
Contributor

Not sure I understand: so or is an array but and isn't? Shouldn't they behave similarly?

@trieloff
Copy link
Contributor Author

Both should be arrays. The example that @tripodsan linked should be invalid. I'll have a look at the schema.

trieloff added a commit that referenced this issue Apr 24, 2019
@trieloff
fix(conditions): restrict conditions schema
55e506c 
`and` and `or` must be arrays. `conditions` and `not` must have exactly one property

Fixes #95 and fixes #96
@trieloff trieloff mentioned this issue Apr 24, 2019
Merged
adobe-bot pushed a commit that referenced this issue Apr 25, 2019
@semantic-release-bot
chore(release): 0.10.4 [skip ci]
d746cbd 
## [0.10.4](v0.10.3...v0.10.4) (2019-04-25)

### Bug Fixes

* **conditions:** restrict conditions schema ([55e506c](55e506c)), closes [#95](#95) [#96](#96)
@adobe-bot
Copy link

🎉 This issue has been resolved in version 0.10.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(conditions): restrict conditions schema adobe/helix-shared
3 participants
@trieloff @dominique-pfister @adobe-bot