Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Multiple Configs #206

Merged
merged 19 commits into from
Dec 20, 2019
Merged

Support for Multiple Configs #206

merged 19 commits into from
Dec 20, 2019

Conversation

trieloff
Copy link
Contributor

@trieloff trieloff commented Dec 19, 2019

adds support for:

Note: this will conflict with #195, as it contains a more generalized and streamlined version of the schema-based config handler. Once this has been merged, I'll update #195 (the schemas can stay as they are)

@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #206 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
+ Coverage   99.66%   99.69%   +0.02%     
==========================================
  Files          17       23       +6     
  Lines        1211     1296      +85     
  Branches      292      303      +11     
==========================================
+ Hits         1207     1292      +85     
  Misses          4        4
Impacted Files Coverage Δ
src/NamedPairHandler.js 100% <100%> (ø)
src/BaseConfig.js 100% <100%> (ø)
src/IndexConfig.js 100% <100%> (ø)
src/SchemaDerivedConfig.js 100% <100%> (ø)
src/HelixConfig.js 100% <100%> (ø) ⬆️
src/NamedMapHandler.js 100% <100%> (ø)
src/index.js 100% <100%> (ø) ⬆️
src/MountConfig.js 100% <100%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e92b2b0...58cc52c. Read the comment docs.

@adobe adobe deleted a comment from lgtm-com bot Dec 19, 2019
@trieloff trieloff marked this pull request as ready for review December 19, 2019 19:25
@trieloff trieloff merged commit c5f1183 into master Dec 20, 2019
@trieloff trieloff deleted the multi-config branch December 20, 2019 08:44
@adobe-bot
Copy link

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants