Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema for named strains and strains as list #73

Closed
wants to merge 2 commits into from

Conversation

trieloff
Copy link
Contributor

As an alternative to #72, here is a possible implementation of strains as lists in JSON Schema as described here:
#71 (comment)

@trieloff trieloff requested a review from tripodsan March 22, 2019 09:38
@ghost
Copy link

ghost commented Mar 22, 2019

There were the following issues with this Pull Request

  • Commit: 4ba7734
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@ghost
Copy link

ghost commented Mar 22, 2019

There were the following issues with this Pull Request

  • Commit: 4ba7734
    • ✖ message may not be empty
    • ✖ type may not be empty
  • Commit: a58519f
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #73 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #73   +/-   ##
======================================
  Coverage    98.9%   98.9%           
======================================
  Files          14      14           
  Lines        1006    1006           
  Branches      221     221           
======================================
  Hits          995     995           
  Misses         11      11
Impacted Files Coverage Δ
src/ConfigValidator.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d532818...a58519f. Read the comment docs.

Copy link
Contributor

@tripodsan tripodsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since helix is still incubating, I think we should not be backward compatible in the schema and only define the array-type.

@tripodsan
Copy link
Contributor

btw, the following is not valid:

version: 1
strains:
  - name: default
    origin: https://www.example.com

see my comment in #75 (comment)

@trieloff trieloff closed this Mar 27, 2019
@tripodsan tripodsan deleted the strain-list-schema branch July 11, 2019 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants