esi:include not stable

[tripodsan]

@davidnuescheler reported, that when having several esi includes on the site, the HTML is sometimes corrupted....

[tripodsan]

adobe/helix-pipeline#227

[tripodsan]

endless loop issue on typo: Schibsted-Tech-Polska/nodesi#10

[tripodsan]

the problem seems to be that the pipeline removes the empty tag marker from the tag. eg:

<div>
    <esi:include src="/head.plain.html" />
    <esi:include src="/header.plain.html" />
</div>

becomes

<div>
    <esi:include src="/head.plain.html">
    <esi:include src="/header.plain.html">
</esi:include></esi:include></div>

when it reaches the ESI processor....

if it's followed by a closing tag, then it works:

<div>
    <esi:include src="/head.plain.html" />
</div>

is transformed to:

<div>
    <esi:include src="/head.plain.html">
</esi:include></div>

[trieloff]

Please see explanation here: adobe/helix-pipeline#317 (comment)

tl;dr: <esi include src="…" /> is invalid, use <esi include src="…" ></esi:include> instead.

[tripodsan]

REOPEN: there is still a bug in nodesi that produces an endless loop...

[adobe-bot]

🎉 This issue has been resolved in version 2.12.8 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀