Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPM install command in README #6

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

Albert-IV
Copy link

Description

The npm install command wasn't pointed to the correct NPM package. This PR fixes #5.

Related Issue

#5

Motivation and Context

I was annoyed the command didn't work as expected.

How Has This Been Tested?

N/A, documentation change.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Albert-IV Albert-IV closed this Mar 11, 2023
@Albert-IV Albert-IV reopened this Mar 11, 2023
@Albert-IV
Copy link
Author

I signed the CLA before opening the PR, I'm not sure why it's not being pulled in.

@MichaelGoberling
Copy link

@Albert-IV

Thanks for the contribution! Just to verify - In addition to filling out the name & e-mail form on the initial CLA link, did you get an e-mail with an Adobe Sign link and fill out that form as well?

@Albert-IV
Copy link
Author

Ooh, I don't think I did. I resubmitted the CLA and completed the 2nd signing process through my email. I think this should all be set now!

@Albert-IV Albert-IV closed this Aug 10, 2023
@Albert-IV Albert-IV reopened this Aug 10, 2023
@MichaelGoberling MichaelGoberling merged commit a1e9a59 into adobe:master Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README contains wrong package name for npm install
2 participants