Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for cyclic schemas #186

Merged
merged 5 commits into from
Dec 20, 2019
Merged

Fix for cyclic schemas #186

merged 5 commits into from
Dec 20, 2019

Conversation

trieloff
Copy link
Collaborator

I thought I'd already merged this one. It is the fix for #185

@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #186 into master will decrease coverage by 0.25%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
- Coverage     100%   99.75%   -0.25%     
==========================================
  Files           8        8              
  Lines         396      400       +4     
==========================================
+ Hits          396      399       +3     
- Misses          0        1       +1
Impacted Files Coverage Δ
lib/markdownBuilder.js 100% <100%> (ø) ⬆️
lib/traverseSchema.js 100% <100%> (ø) ⬆️
lib/formattingTools.js 94.11% <80%> (-5.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9fb2ca...af85c59. Read the comment docs.

@trieloff trieloff merged commit 75cd8f8 into master Dec 20, 2019
@trieloff
Copy link
Collaborator Author

🎉 This PR is included in version 4.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tripodsan tripodsan deleted the cyclic-schemas branch March 25, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant