-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SCB support for ssh operations #108
Conversation
Fix code scanning results and then +1 |
src/ops/cli/parser.py
Outdated
@@ -109,5 +109,7 @@ def configure_common_ansible_args(parser): | |||
help='Ask sudo pass for commands that need sudo') | |||
parser.add_argument('--limit', type=str, | |||
help='Limit run to a specific server subgroup. Eg: --limit newton-dcs') | |||
parser.add_argument('--noscb', action='store_false', dest='use_scb', | |||
help='Disable use of Shell Control Box (SCB) even it is enabled in the cluster config') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/it/if/g
src/ops/cli/ssh.py
Outdated
'--noscb', | ||
action='store_false', | ||
dest='use_scb', | ||
help='Disable use of Shell Control Box (SCB) even it is enabled in the cluster config') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/it/if/g
src/ops/cli/sync.py
Outdated
@@ -26,6 +28,8 @@ def configure(self, parser): | |||
help='Value for remote user that will be used for ssh') | |||
parser.add_argument('src', type=str, help='Source dir') | |||
parser.add_argument('dest', type=str, help='Dest dir') | |||
parser.add_argument('--noscb', action='store_false', dest='use_scb', | |||
help='Disable use of Shell Control Box (SCB) even it is enabled in the cluster config') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
Shell Control Box (SCB) is an activity monitoring appliance from Balabit (now One Identity) that controls privileged access to remote servers. Added support for using ops with SCB for the following operations: ssh, tunnel, proxy, ansible play, run and sync
Description
Shell Control Box (SCB) is an activity monitoring appliance from Balabit (now One Identity) that controls privileged access to remote servers.
Added support for using ops with SCB for the following operations: ssh, tunnel, proxy, ansible play, run and sync
Motivation and Context
In my organisation using SCB will be mandatory for security reasons and ops-cli is already being used.
How Has This Been Tested?
Used ops-cli with an aws cluster for the following operations:
All operations were tested in each of the following scenario:
Types of changes
Checklist: