Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs are not getting rendered in specific scenario #6753

Closed
Makisuo opened this issue Jul 23, 2024 · 2 comments · Fixed by #6755
Closed

Tabs are not getting rendered in specific scenario #6753

Makisuo opened this issue Jul 23, 2024 · 2 comments · Fixed by #6755

Comments

@Makisuo
Copy link
Contributor

Makisuo commented Jul 23, 2024

Provide a general summary of the issue here

I'm using React Aria Tabs together in MDX. It used to work great but since 1.30 they stopped rendering all together.

No error is thrown, nor is any markup rendered whatsoever.

🤔 Expected Behavior?

The TabList and its Panels should be rendered as normally expected.

😯 Current Behavior

No error is thrown and no Markup is being rendered.
Nothing inside of Tabs will get rendered.

💁 Possible Solution

It does still work as expected once downgrading to 1.2.2

🔦 Context

We are using Tabs inside of our docs to render Examples and it's Code Snippet. Our Docs are build with MDX and we insert all MDX components as seen here

This has stopped working with 1.3.0

The component in quesiton be found here:
https://github.com/telekom/pixelshades/blob/main/apps/docs/src/components/component-preview.tsx

🖥️ Steps to Reproduce

Not sure how to reproduce it, I tried to create a minimal production right here
But it works here so I don't know what the exact issue is here.

Here is the broken branch of our Docs Examples being broken:
https://github.com/telekom/pixelshades/tree/react-aria-1.3.0

Docs can be started with bun run dev --filter docs

Version

1.3.0

What browsers are you seeing the problem on?

Firefox, Chrome, Safari, Microsoft Edge

If other, please specify.

No response

What operating system are you using?

MacOS

🧢 Your Company/Team

T-Systems

🕷 Tracking Issue

No response

@Makisuo Makisuo changed the title Tabs are not getting rendered in Tabs are not getting rendered in specific scenario Jul 23, 2024
@devongovett
Copy link
Member

This should be fixed in v1.3.1.

@Makisuo
Copy link
Contributor Author

Makisuo commented Jul 24, 2024

Thanks, works now! Completly missed I rendered Tabs in Tabs 🤦‍♂️.
Was so confused what could have broken it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants