Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch fixes #6755

Merged
merged 4 commits into from
Jul 23, 2024
Merged

Patch fixes #6755

merged 4 commits into from
Jul 23, 2024

Conversation

devongovett
Copy link
Member

@rspbot
Copy link

rspbot commented Jul 23, 2024

@rspbot
Copy link

rspbot commented Jul 23, 2024

## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }

@react-aria/collections

createLeafComponent

 createLeafComponent<E extends Element, P extends {}> {
   type: string
-  render: (P, ForwardedRef<E>, any) => ReactNode
+  render: (P, ForwardedRef<E>, any) => ReactElement
   returnVal: undefined
 }

createBranchComponent

 createBranchComponent<E extends Element, P extends {
     children?: any
 }, T extends {}> {
   type: string
-  render: (P, ForwardedRef<E>, Node<T>) => ReactNode
+  render: (P, ForwardedRef<E>, Node<T>) => ReactElement
   useChildren: (P) => ReactNode
   returnVal: undefined
 }

createHideableComponent

 createHideableComponent<P = {
   
 }, T> {
-  fn: (P, React.Ref<T>) => ReactNode | null
+  fn: (P, React.Ref<T>) => ReactElement | null
   returnVal: undefined
 }

@react-aria/utils

scrollIntoView

-
+getSyntheticLinkProps {
+  props: LinkDOMProps
+  returnVal: undefined
+}

Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ktabors ktabors mentioned this pull request Jul 23, 2024
5 tasks
@devongovett devongovett merged commit 3013156 into main Jul 23, 2024
28 checks passed
@devongovett devongovett deleted the patch-fixes branch July 23, 2024 19:52
Copy link

@vtantai99 vtantai99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me !

You save my life <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants