Enable TS strict mode for React Aria Components #4225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
|
Build successful! 🎉 |
snowystinger
previously approved these changes
Mar 17, 2023
devongovett
force-pushed
the
aria-components-ts-strict
branch
from
6e86bfd
to
3e6b367
Compare
|
Build successful! 🎉 |
|
Build successful! 🎉 |
…onents-ts-strict # Conflicts: # packages/react-aria-components/docs/Table.mdx # packages/react-aria-components/src/Collection.tsx # packages/react-aria-components/src/GridList.tsx # packages/react-aria-components/src/ListBox.tsx # packages/react-aria-components/src/Table.tsx # packages/react-aria-components/src/utils.tsx
|
Merged in main, and updated the drag and drop examples and code to TS strict as well. In order to make this nicer, I also added |
|
Build successful! 🎉 |
snowystinger
approved these changes
Mar 21, 2023
reidbarber
approved these changes
Mar 21, 2023
ktabors
approved these changes
Mar 21, 2023
| @@ -842,8 +842,13 @@ function DraggableListBox() { | |||
| Dropping on the ListBox as a whole can be enabled using the `onRootDrop` event. When a valid drag hovers over the ListBox, it receives the `isDropTarget` state and can be styled using the `[data-drop-target]` CSS selector. | |||
|
|
|||
| ```tsx example | |||
| interface Item { | |||
There was a problem hiding this comment.
I feel like this should be a type we export since it's used a couple times, but it's just for examples to show what to do.
|
Build successful! 🎉 |
|
## API Changes
unknown top level export { type: 'identifier', name: 'Column' } @react-aria/dndisVirtualDragging-
+isDirectoryDropItem {
+ dropItem: DropItem
+ returnVal: undefined
+}isDirectoryDropItem-
+isFileDropItem {
+ dropItem: DropItem
+ returnVal: undefined
+}isFileDropItem-
+isTextDropItem {
+ dropItem: DropItem
+ returnVal: undefined
+}@react-aria/tabsuseTabListchanged by:
useTabList<T> {
- props: AriaTabListProps<T>
+ props: AriaTabListOptions<T>
state: TabListState<T>
ref: RefObject<HTMLElement>
returnVal: undefined
}AriaTabListOptions+AriaTabListOptions<T> {
+}it changed:
@react-aria/utilsmergeProps-mergeProps<T extends Array<Props>> {
- args: T
- returnVal: undefined
-}
+isVirtualPointerEvent-
+mergeProps<T extends Array<PropsArg>> {
+ args: T
+ returnVal: undefined
+}@react-stately/calendaruseCalendarStatechanged by:
-useCalendarState {
- props: CalendarStateOptions
- returnVal: undefined
-}
+useRangeCalendarStatechanged by:
-useRangeCalendarState {
- props: RangeCalendarStateOptions
- returnVal: undefined
-}
+CalendarStateOptions-CalendarStateOptions {
- createCalendar: (string) => Calendar
- locale: string
- selectionAlignment?: 'start' | 'center' | 'end'
- visibleDuration?: DateDuration = {months: 1}
-}
+it changed:
RangeCalendarStateOptions-RangeCalendarStateOptions {
- createCalendar: (string) => Calendar
- locale: string
- visibleDuration?: DateDuration = {months: 1}
-}
+it changed:
undefined-
+useCalendarState<T extends DateValue = DateValue> {
+ props: CalendarStateOptions<T>
+ returnVal: undefined
+}undefined-
+useRangeCalendarState<T extends DateValue = DateValue> {
+ props: RangeCalendarStateOptions<T>
+ returnVal: undefined
+}undefined-
+CalendarStateOptions<T extends DateValue = DateValue> {
+ createCalendar: (string) => Calendar
+ locale: string
+ selectionAlignment?: 'start' | 'center' | 'end'
+ visibleDuration?: DateDuration = {months: 1}
+}undefined-
+RangeCalendarStateOptions<T extends DateValue = DateValue> {
+ createCalendar: (string) => Calendar
+ locale: string
+ visibleDuration?: DateDuration = {months: 1}
+}@react-stately/datepickeruseDateFieldStatechanged by:
-useDateFieldState {
- props: DateFieldStateOptions
- returnVal: undefined
-}
+useDateRangePickerStatechanged by:
-useDateRangePickerState {
- props: DateRangePickerStateOptions
- returnVal: undefined
-}
+useTimeFieldStatechanged by:
-useTimeFieldState {
- props: TimeFieldStateOptions
- returnVal: undefined
-}
+DateFieldStateOptions-DateFieldStateOptions {
- createCalendar: (string) => Calendar
- locale: string
- maxGranularity?: 'year' | 'month' | Granularity = 'year'
-}
+it changed:
DateRangePickerStateOptions-DateRangePickerStateOptions {
- shouldCloseOnSelect?: boolean | () => boolean = true
-}
+it changed:
TimeFieldStateOptions-TimeFieldStateOptions {
- locale: string
-}
+it changed:
undefined-
+useDateFieldState<T extends DateValue = DateValue> {
+ props: DateFieldStateOptions<T>
+ returnVal: undefined
+}undefined-
+useDateRangePickerState<T extends DateValue = DateValue> {
+ props: DateRangePickerStateOptions<T>
+ returnVal: undefined
+}undefined-
+useTimeFieldState<T extends TimeValue = TimeValue> {
+ props: TimeFieldStateOptions<T>
+ returnVal: undefined
+}undefined-
+DateFieldStateOptions<T extends DateValue = DateValue> {
+ createCalendar: (string) => Calendar
+ locale: string
+ maxGranularity?: 'year' | 'month' | Granularity = 'year'
+}undefined-
+DateRangePickerStateOptions<T extends DateValue = DateValue> {
+ shouldCloseOnSelect?: boolean | () => boolean = true
+}undefined-
+TimeFieldStateOptions<T extends TimeValue = TimeValue> {
+ locale: string
+} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #4212.
This converts the code and examples for React Aria Components to TS strict mode. It also improves the types for:
nullto thevalueprop types. Part of DateRangePicker's controlled value can't be set to null to show the placeholder instead of the previous selected date #3187.childrenas a required prop foruseTabList.isTextDropItem,isFileDropItem, andisDirectoryDropItemfunctions which act as TS type predicates.