Fix useMenuItem onAction regression #6807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LFDanLu
approved these changes
Aug 1, 2024
| it('calls an onAction passed directly to useMenuItem', async () => { | ||
| let onSelect = jest.fn(); | ||
| let {getAllByRole} = render( | ||
| <Menu onSelect={onSelect} aria-label={'test menu'}> |
There was a problem hiding this comment.
Ah interesting, so this is a route where the user passes their onAction equivalent at the menu level but routes it directly to the useMenuItem hook. I think when you and I discussed this previously that I had made an erroneous assumption that it would always be passed to the Menu or the Item as onAction directly whoops
There was a problem hiding this comment.
Yeah, all good, I didn't really understand until I saw an example as well.
reidbarber
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6804
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: