feat: update site name in site entity #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will trigger a patch release when merged. |
sandsinh
changed the title
2 tasks
sandsinh
added a commit
to adobe/spacecat-shared
that referenced
this pull request
Feb 18, 2025
Problem: PSS UI is rendering baseURL in several places. We need human friendly name for each site to render on all the pages in PSS UI. This PR adds a name attribute in Site schema and changes to update from PATCH call. spacecat-api-service changes - adobe/spacecat-api-service#752 Request: `curl --request PATCH \ --url https://spacecat.experiencecloud.live/api/ci/sites/{siteId} \ --header 'Content-Type: application/json' \ --header 'authorization: Bearer <token>' \ --data '{ "name": "SITE NAME" }'` Response: `{ "id": "123", "baseURL": "https://example.com", "name": "SITE NAME", "hlxConfig": {}, "deliveryType": "aem_cs", "organizationId": "org-id", "isLive": false, "isLiveToggledAt": "2025-01-07T10:54:22.455Z", "createdAt": "2025-01-07T10:54:22.453Z", "updatedAt": "2025-02-17T13:16:51.873Z", "config": { "slack": {}, "handlers": { } } }` Please ensure your pull request adheres to the following guidelines: - [ ] make sure to link the related issues in this description - [ ] when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes ## Related Issues Thanks for contributing!
solaris007
approved these changes
Feb 18, 2025
@solaris007 I will create some follow up PRs for using this. Slack command updates will be part of that. |
solaris007
pushed a commit
that referenced
this pull request
Feb 18, 2025
# [1.92.0](v1.91.3...v1.92.0) (2025-02-18) ### Features * update site name in site entity ([#752](#752)) ([06fd024](06fd024))
|
🎉 This PR is included in version 1.92.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
PSS UI is rendering baseURL in several places. We need human friendly name for each site to render on all the pages in PSS UI. This PR adds a name attribute in Site schema and changes to update from PATCH call.
API spec changes - adobe/spacecat-shared#605
Request:
curl --request PATCH \ --url https://spacecat.experiencecloud.live/api/ci/sites/{siteId} \ --header 'Content-Type: application/json' \ --header 'authorization: Bearer <token>' \ --data '{ "name": "SITE NAME" }'Response:
{ "id": "123", "baseURL": "https://example.com", "name": "SITE NAME", "hlxConfig": {}, "deliveryType": "aem_cs", "organizationId": "org-id", "isLive": false, "isLiveToggledAt": "2025-01-07T10:54:22.455Z", "createdAt": "2025-01-07T10:54:22.453Z", "updatedAt": "2025-02-17T13:16:51.873Z", "config": { "slack": {}, "handlers": { } } }Please ensure your pull request adheres to the following guidelines:
describe here the problem you're solving.
If the PR is changing the API specification:
yet. Ideally, return a 501 status code with a message explaining the feature is not implemented yet.
If the PR is changing the API implementation or an entity exposed through the API:
If the PR is introducing a new audit type:
Related Issues
Thanks for contributing!