fix: minor fixes to forms opportunity (#614)

adobe · Jan 31, 2025 · 4f408b6 · 4f408b6
1 parent 0e60748
commit 4f408b6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/forms-opportunities/opportunityHandler.js b/src/forms-opportunities/opportunityHandler.js
@@ -21,7 +21,7 @@ export default async function convertToOpportunity(auditUrl, auditData, context)
   const { dataAccess, log } = context;
   const { Opportunity } = dataAccess;
 
-  // log.info(`Syncing opportunity for ${auditData.siteId}`);
+  log.info(`Syncing opportunity for ${auditData.siteId}`);
   let highFormViewsLowConversionsOppty;
 
   try {
@@ -43,10 +43,10 @@ export default async function convertToOpportunity(auditUrl, auditData, context)
         const opportunityData = {
           siteId: auditData.siteId,
           auditId: auditData.id,
-          runbook: 'https://adobe.sharepoint.com/:w:/r/sites/AEM_Forms/Shared%20Documents/ESS/Runbook/High%20Form%20Views%20Low%20Conversions.docx?d=wb5aadc4fda7d4833973f2af60c4668e3&csf=1&web=1&e=0iaKdE',
+          runbook: 'https://adobe.sharepoint.com/:w:/s/AEM_Forms/EU_cqrV92jNIlz8q9gxGaOMBSRbcwT9FPpQX84bRKQ9Phw?e=Nw9ZRz',
           type: 'high-form-views-low-conversions',
           origin: 'AUTOMATION',
-          title: 'Contact Us Form has high views but low conversions',
+          title: 'Form has high views but low conversions',
           description: 'Form has high views but low conversions',
           tags: ['Forms Conversion'],
           data: {

diff --git a/src/forms-opportunities/utils.js b/src/forms-opportunities/utils.js
@@ -10,7 +10,7 @@
  * governing permissions and limitations under the License.
  */
 const DAILY_PAGEVIEW_THRESHOLD = 200;
-const CR_THRESHOLD_RATIO = 0.2;
+const CR_THRESHOLD_RATIO = 0.3;
 const MOBILE = 'mobile';
 const DESKTOP = 'desktop';
 

diff --git a/test/fixtures/high-form-views-low-conversions.js b/test/fixtures/high-form-views-low-conversions.js
@@ -51,10 +51,10 @@ const testData = {
   opportunityData: {
     siteId: 'site-id',
     auditId: 'audit-id',
-    runbook: 'https://adobe.sharepoint.com/:w:/r/sites/AEM_Forms/Shared%20Documents/ESS/Runbook/High%20Form%20Views%20Low%20Conversions.docx?d=wb5aadc4fda7d4833973f2af60c4668e3&csf=1&web=1&e=0iaKdE',
+    runbook: 'https://adobe.sharepoint.com/:w:/s/AEM_Forms/EU_cqrV92jNIlz8q9gxGaOMBSRbcwT9FPpQX84bRKQ9Phw?e=Nw9ZRz',
     type: 'high-form-views-low-conversions',
     origin: 'AUTOMATION',
-    title: 'Contact Us Form has high views but low conversions',
+    title: 'Form has high views but low conversions',
     description: 'Form has high views but low conversions',
     tags: [
       'Forms Conversion',